Synchronize writes across all instances of ConsoleSink #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skomis-mm
approved these changes
Aug 1, 2019
2 tasks
|
I made a different decision, after chatting with @nblumhardt we thought it might be useful, but still a little undecided. So I pushed it and made pr #66. Probably we can consider that change as a breaking change for the next major version increment. |
Merged
|
Is this only a "breaking" change because the output is no longer interleaved, or is it genuinely incompatible with a component expecting 3.1.1 (for example?) |
|
@oising the binary signature of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each instance of
ConsoleSinkis synchronized so that concurrent output is not interleaved.Some scenarios, like reinitialization of the logging pipeline, non-singleton loggers, and Serilog.Sinks.Map can result in multiple instances of
ConsoleSinkbeing constructed, and today these will happily interleave output. (E.g. see serilog/serilog#1350 .)This PR switches the lock from sink-specific to shared, so that at least all writes through console sinks will be non-interleaved (even if other console output isn't controlled this way).
CC @skomis-mm